utils: Move ResultExt to bootc_utils #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the ResultExt trait by moving it from ostree-ext to the more general bootc-utils crate, making it available for wider use. The changes are clean and achieve the stated goal. I have one suggestion to make the implementation of log_err_or_else more idiomatic by using a standard library function, which improves conciseness and maintainability.
ckyrouac
approved these changes
Jul 30, 2025
This way it can be more easily used elsewhere. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
utilstracing-log-err
branch
from
2cda36f to
bdd600e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it can be more easily used elsewhere.